Skip to content
Snippets Groups Projects
  1. Mar 19, 2015
  2. Feb 23, 2015
  3. Feb 20, 2015
  4. Feb 17, 2015
  5. Dec 23, 2014
  6. Dec 12, 2014
  7. Dec 10, 2014
  8. Nov 27, 2014
  9. Nov 11, 2014
  10. Nov 04, 2014
  11. Oct 08, 2014
  12. Oct 06, 2014
  13. Sep 15, 2014
  14. Sep 09, 2014
  15. Aug 15, 2014
  16. Aug 14, 2014
  17. Jun 27, 2014
  18. Jun 03, 2014
  19. May 19, 2014
  20. May 17, 2014
  21. May 10, 2014
  22. May 09, 2014
  23. May 05, 2014
  24. Apr 22, 2014
  25. Apr 02, 2014
  26. Apr 01, 2014
  27. Mar 26, 2014
  28. Mar 19, 2014
    • Josh Watzman's avatar
      [show-hint addon] Fix race with async enabled · 3f695290
      Josh Watzman authored
      Summary: If `options.async` is enabled, it's possible for `activity` to
      be called a second time before the first call's paired `finishUpdate` is
      triggered. Then, when the second call to `finishUpdate` happens, the
      still-active widget in `completion.widget` is unceremoneously
      overwritten and can now never be closed. This leads to a lot of weird
      and broken behavior, notably an autocomplete window in the browser that
      never goes away and can insert its text over and over and over.
      
      Test Plan: This is really hard to trigger. My project consists of a
      webworker providing autocomplete, which has some latency before it calls
      the `finishUpdate` callback. But it depends on the exact latency and
      even the user's typing speed to whether things happen in just the right
      order. I basically just added and deleted characters with the
      autocomplete prompt open a bunch until it eventually reproduced. After
      applying this patch, several minutes of bashing didn't trigger the issue
      again.
      3f695290
  29. Mar 12, 2014
  30. Mar 05, 2014
  31. Mar 04, 2014
Loading