Skip to content
Snippets Groups Projects
  1. Mar 19, 2014
    • Marijn Haverbeke's avatar
    • Josh Watzman's avatar
      [show-hint addon] Fix race with async enabled · 3f695290
      Josh Watzman authored
      Summary: If `options.async` is enabled, it's possible for `activity` to
      be called a second time before the first call's paired `finishUpdate` is
      triggered. Then, when the second call to `finishUpdate` happens, the
      still-active widget in `completion.widget` is unceremoneously
      overwritten and can now never be closed. This leads to a lot of weird
      and broken behavior, notably an autocomplete window in the browser that
      never goes away and can insert its text over and over and over.
      
      Test Plan: This is really hard to trigger. My project consists of a
      webworker providing autocomplete, which has some latency before it calls
      the `finishUpdate` callback. But it depends on the exact latency and
      even the user's typing speed to whether things happen in just the right
      order. I basically just added and deleted characters with the
      autocomplete prompt open a bunch until it eventually reproduced. After
      applying this patch, several minutes of bashing didn't trigger the issue
      again.
      3f695290
    • Marijn Haverbeke's avatar
      Only call signalLater for "markerAdded" when cm exists · 7e53bcce
      Marijn Haverbeke authored
      Issue #2390
      7e53bcce
    • dignifiedquire's avatar
  2. Mar 18, 2014
  3. Mar 17, 2014
  4. Mar 15, 2014
  5. Mar 13, 2014
  6. Mar 12, 2014
  7. Mar 11, 2014
  8. Mar 10, 2014
  9. Mar 09, 2014
  10. Mar 08, 2014
    • Yunchi Luo's avatar
      [vim] Fix :registers unit tests · 809fe262
      Yunchi Luo authored
      809fe262
    • Travis Heppe's avatar
      [vim] Refactor macro handling · 96b8519b
      Travis Heppe authored
      Use CreateInsertModeChanges to make a copy of the latest
      insert mode changes in pushInsertModeChanges so that the
      latest insert mode changes can safely be modified without
      bashing previously recorded macros.
      
      Fix the :register command and add unit tests. Add a fakeOpenNotification for matching the notification text.
      96b8519b
  11. Mar 07, 2014
  12. Mar 06, 2014
Loading