Skip to content
Snippets Groups Projects
  1. Jan 30, 2018
  2. Jan 29, 2018
  3. Jan 27, 2018
  4. Jan 26, 2018
  5. Jan 19, 2018
  6. Jan 18, 2018
  7. Jan 17, 2018
    • silverwind's avatar
    • neon-dev's avatar
      [javascript-lint addon] Fix error markers · 81fc4f5a
      neon-dev authored
      When using tabs for indentation, the markers would not always align with the actual problem.
      The old workaround for JSHint never really worked (only when a line had one tab) and I found a simple option which fixes the issue.
      This time I also checked backwards compatibility, which works even fine with the old JSHint version R07.
      As a second marker fix, I added an error line check, since JSHint for some reason adds configuration issues in the errors array with line: 0, character: 0. Now, if you pass an invalid option you will get a console error instead of an invisible marker.
      81fc4f5a
    • neon-dev's avatar
      [lint demo] Added JS error · 2ececac0
      neon-dev authored
      As of 1d5c828f the missing js semicolon is a warning and not an error anymore, therefore I added an error elsewhere.
      2ececac0
    • neon-dev's avatar
    • neon-dev's avatar
      81391e6a
    • neon-dev's avatar
      dac3bdec
    • neon-dev's avatar
      [javascript-lint addon] Fix incorrect severity · d8d68a8a
      neon-dev authored
      When enabling strict equality checks via `lint: {options: {eqeqeq: true}}`, found problems showed up as errors instead of warnings.
      To fix it, the `fixWith()` logic had to be changed since simply adding the phrase to the warnings array would not have worked. This is because both the warnings and errors array matched this exact error and therefore the severity could never be "warning" (errors were checked after warnings).
      
      I didn't include "Missing property name" and "Unmatched " in the new error array since they already are errors with the new logic.
      "Stopping, unable to continue" also got removed since it didn't appear anywhere in the current jshint.js.
      
      For now I've implemented everything to not break previous behavior/hinting, except the strict equality hint severity. Although I want to suggest removing the following codes from the new error array (so they can stay warnings):
      - W033 (Missing semicolon) - since erroneous missing semicolons have their own code: E058
      - W084 (Expected a conditional expression and instead saw an assignment) - since something like `switch (var2 = var1 + 42)` is valid js code, though not recommendable
      - maybe W023/24/30/90, since there are many more " and instead saw an" hints that are already errors with their own codes, so I think they should be pretty accurate. Unfortunately I couldn't force these warnings so I couldn't check.
      d8d68a8a
    • Marijn Haverbeke's avatar
      97418246
  8. Jan 13, 2018
  9. Jan 12, 2018
  10. Jan 11, 2018
  11. Jan 10, 2018
  12. Jan 09, 2018
  13. Jan 08, 2018
  14. Jan 07, 2018
  15. Jan 01, 2018
  16. Dec 30, 2017
  17. Dec 29, 2017
  18. Dec 24, 2017
  19. Dec 22, 2017
  20. Dec 21, 2017
Loading