Skip to content
Snippets Groups Projects
  1. May 13, 2014
  2. May 10, 2014
  3. May 09, 2014
  4. May 06, 2014
  5. May 05, 2014
  6. May 03, 2014
  7. May 02, 2014
  8. Apr 25, 2014
  9. Apr 22, 2014
  10. Apr 09, 2014
  11. Apr 08, 2014
  12. Apr 07, 2014
  13. Apr 02, 2014
  14. Apr 01, 2014
  15. Mar 26, 2014
  16. Mar 20, 2014
  17. Mar 19, 2014
    • Josh Watzman's avatar
      [show-hint addon] Fix race with async enabled · 3f695290
      Josh Watzman authored
      Summary: If `options.async` is enabled, it's possible for `activity` to
      be called a second time before the first call's paired `finishUpdate` is
      triggered. Then, when the second call to `finishUpdate` happens, the
      still-active widget in `completion.widget` is unceremoneously
      overwritten and can now never be closed. This leads to a lot of weird
      and broken behavior, notably an autocomplete window in the browser that
      never goes away and can insert its text over and over and over.
      
      Test Plan: This is really hard to trigger. My project consists of a
      webworker providing autocomplete, which has some latency before it calls
      the `finishUpdate` callback. But it depends on the exact latency and
      even the user's typing speed to whether things happen in just the right
      order. I basically just added and deleted characters with the
      autocomplete prompt open a bunch until it eventually reproduced. After
      applying this patch, several minutes of bashing didn't trigger the issue
      again.
      3f695290
  18. Mar 17, 2014
  19. Mar 12, 2014
  20. Mar 10, 2014
  21. Mar 09, 2014
  22. Mar 05, 2014
  23. Mar 04, 2014
Loading