Skip to content
Snippets Groups Projects
  1. Apr 27, 2018
  2. Apr 25, 2018
  3. Apr 20, 2018
    • wonderboyjon's avatar
      [sql-hint addon] Add semantic classes to different types of hints · 6041c228
      wonderboyjon authored
      By adding classes that clearly define when a hint is a table or a keyword, it gives developers easy control if they wish to style hints differently. For example, you may wish to style table hints in a different colour to keywords (to make them easier to distinguish).
      6041c228
  4. Apr 12, 2018
  5. Mar 21, 2018
    • Raymond Hill's avatar
      [merge addon] Fix edge case arising when diff'ing empty strings · f56b0d2d
      Raymond Hill authored
      The merge view will incorrectly show a "Revert chunk" arrow when
      the text on both sides of the view are the empty string.
      
      The getChunks() helper is not prepared to deal with an empty diff
      array.
      
      The getDiff() helper returns an empty diff array when both strings
      to compare are empty, as the only diff item returned by
      diff_match_patch, `[0, ""]`, is removed as a result of the diff
      entry containing an empty string.
      
      The chosen (trivial) fix is to simply check for the empty diff
      array case at the top of getChunks().
      f56b0d2d
  6. Mar 20, 2018
  7. Mar 19, 2018
    • neon-dev's avatar
      [javascript-hint addon] Disable completion in json mode · 45d5e05a
      neon-dev authored
      When using the editor in "application/json" mode, the standard javascript autocompletion would show up once triggered. Although it's deactivated by default and doesn't make sense to enable autocompletion in JSON mode on its own, this change fixes incorrect completions once you combine the default completion with your own custom logic.
      45d5e05a
  8. Mar 17, 2018
    • Raymond Hill's avatar
      [merge addon] Use CSS :after to style scroll-lock icon · 261d10b8
      Raymond Hill authored
      Primary motivation was to remove the use of `innerHTML` because the
      Firefox extension validator raises a warning about this.
      
      The obvious solution is to use `textContent` instead of `innerHTML`
      but I thought it could be useful to have the ability to pick a
      custom visual for the scroll-lock icon.
      
      As per MDN documentation, all the supported browsers as per
      CodeMirror documentation support `:after`.
      261d10b8
  9. Mar 09, 2018
  10. Feb 21, 2018
  11. Feb 20, 2018
  12. Feb 13, 2018
  13. Feb 08, 2018
  14. Jan 27, 2018
  15. Jan 17, 2018
    • neon-dev's avatar
      [javascript-lint addon] Fix error markers · 81fc4f5a
      neon-dev authored
      When using tabs for indentation, the markers would not always align with the actual problem.
      The old workaround for JSHint never really worked (only when a line had one tab) and I found a simple option which fixes the issue.
      This time I also checked backwards compatibility, which works even fine with the old JSHint version R07.
      As a second marker fix, I added an error line check, since JSHint for some reason adds configuration issues in the errors array with line: 0, character: 0. Now, if you pass an invalid option you will get a console error instead of an invisible marker.
      81fc4f5a
    • neon-dev's avatar
    • neon-dev's avatar
      dac3bdec
    • neon-dev's avatar
      [javascript-lint addon] Fix incorrect severity · d8d68a8a
      neon-dev authored
      When enabling strict equality checks via `lint: {options: {eqeqeq: true}}`, found problems showed up as errors instead of warnings.
      To fix it, the `fixWith()` logic had to be changed since simply adding the phrase to the warnings array would not have worked. This is because both the warnings and errors array matched this exact error and therefore the severity could never be "warning" (errors were checked after warnings).
      
      I didn't include "Missing property name" and "Unmatched " in the new error array since they already are errors with the new logic.
      "Stopping, unable to continue" also got removed since it didn't appear anywhere in the current jshint.js.
      
      For now I've implemented everything to not break previous behavior/hinting, except the strict equality hint severity. Although I want to suggest removing the following codes from the new error array (so they can stay warnings):
      - W033 (Missing semicolon) - since erroneous missing semicolons have their own code: E058
      - W084 (Expected a conditional expression and instead saw an assignment) - since something like `switch (var2 = var1 + 42)` is valid js code, though not recommendable
      - maybe W023/24/30/90, since there are many more " and instead saw an" hints that are already errors with their own codes, so I think they should be pretty accurate. Unfortunately I couldn't force these warnings so I couldn't check.
      d8d68a8a
  16. Jan 13, 2018
  17. Jan 11, 2018
  18. Jan 10, 2018
  19. Dec 14, 2017
  20. Dec 03, 2017
  21. Dec 01, 2017
  22. Nov 27, 2017
  23. Nov 20, 2017
  24. Nov 07, 2017
  25. Nov 01, 2017
  26. Oct 30, 2017
  27. Oct 29, 2017
  28. Oct 18, 2017
    • Markus Olsson's avatar
      [runmode addon] Include CodeMirror.innerMode in runmode.node.js · deaa842d
      Markus Olsson authored
      The markdown mode uses `CodeMirror.innerMode` which isn't defined in
      the stripped down node runmode. Since markdown is the only mode
      (AFAICT) that uses it I'm not sure if it would make more sense rewrite
      it to not use it but this seemed like the least risky option.
      deaa842d
  29. Oct 16, 2017
Loading