- Apr 27, 2018
-
-
stan-z authored
FIxes #5380
-
- Apr 25, 2018
-
-
christopherblaser authored
-
- Apr 20, 2018
-
-
wonderboyjon authored
By adding classes that clearly define when a hint is a table or a keyword, it gives developers easy control if they wish to style hints differently. For example, you may wish to style table hints in a different colour to keywords (to make them easier to distinguish).
-
- Apr 12, 2018
-
-
Marijn Haverbeke authored
Issue #5179
-
- Mar 21, 2018
-
-
Raymond Hill authored
The merge view will incorrectly show a "Revert chunk" arrow when the text on both sides of the view are the empty string. The getChunks() helper is not prepared to deal with an empty diff array. The getDiff() helper returns an empty diff array when both strings to compare are empty, as the only diff item returned by diff_match_patch, `[0, ""]`, is removed as a result of the diff entry containing an empty string. The chosen (trivial) fix is to simply check for the empty diff array case at the top of getChunks().
-
- Mar 20, 2018
-
-
Marijn Haverbeke authored
Issue #5312
-
neon-dev authored
The hint logic of the `fromList` command did not respect the cursor position inside the token. Now it will list all matching completions for the substring up to the cursor, instead of only the ones matching the complete token. The behavior is now the same as for the regular autocompletion.
-
ryu-sato authored
Closes #5290
-
- Mar 19, 2018
-
-
neon-dev authored
When using the editor in "application/json" mode, the standard javascript autocompletion would show up once triggered. Although it's deactivated by default and doesn't make sense to enable autocompletion in JSON mode on its own, this change fixes incorrect completions once you combine the default completion with your own custom logic.
-
- Mar 17, 2018
-
-
Raymond Hill authored
Primary motivation was to remove the use of `innerHTML` because the Firefox extension validator raises a warning about this. The obvious solution is to use `textContent` instead of `innerHTML` but I thought it could be useful to have the ability to pick a custom visual for the scroll-lock icon. As per MDN documentation, all the supported browsers as per CodeMirror documentation support `:after`.
-
- Mar 09, 2018
-
-
Tom McLaughlin authored
-
- Feb 21, 2018
-
-
Marijn Haverbeke authored
-
- Feb 20, 2018
-
-
Marijn Haverbeke authored
Issue #5265
-
Tom MacWright authored
This explicitly adds keywords that are already syntax-highlighted and correctly parsed by CodeMirror already in the JavaScript mode.
-
- Feb 13, 2018
-
-
Michal Kapiczynski authored
[javascript-lint] JSHINT backward compatibility - Setting error severity to error by default when there is no error.code property (#5260)
-
- Feb 08, 2018
-
-
Marijn Haverbeke authored
Closes #5238
-
- Jan 27, 2018
-
-
Bret Little authored
-
- Jan 17, 2018
-
-
neon-dev authored
When using tabs for indentation, the markers would not always align with the actual problem. The old workaround for JSHint never really worked (only when a line had one tab) and I found a simple option which fixes the issue. This time I also checked backwards compatibility, which works even fine with the old JSHint version R07. As a second marker fix, I added an error line check, since JSHint for some reason adds configuration issues in the errors array with line: 0, character: 0. Now, if you pass an invalid option you will get a console error instead of an invisible marker.
-
neon-dev authored
-
neon-dev authored
-
neon-dev authored
When enabling strict equality checks via `lint: {options: {eqeqeq: true}}`, found problems showed up as errors instead of warnings. To fix it, the `fixWith()` logic had to be changed since simply adding the phrase to the warnings array would not have worked. This is because both the warnings and errors array matched this exact error and therefore the severity could never be "warning" (errors were checked after warnings). I didn't include "Missing property name" and "Unmatched " in the new error array since they already are errors with the new logic. "Stopping, unable to continue" also got removed since it didn't appear anywhere in the current jshint.js. For now I've implemented everything to not break previous behavior/hinting, except the strict equality hint severity. Although I want to suggest removing the following codes from the new error array (so they can stay warnings): - W033 (Missing semicolon) - since erroneous missing semicolons have their own code: E058 - W084 (Expected a conditional expression and instead saw an assignment) - since something like `switch (var2 = var1 + 42)` is valid js code, though not recommendable - maybe W023/24/30/90, since there are many more " and instead saw an" hints that are already errors with their own codes, so I think they should be pretty accurate. Unfortunately I couldn't force these warnings so I couldn't check.
-
- Jan 13, 2018
-
-
Marijn Haverbeke authored
No longer creates a fold spot for both lines of a line-broken tag. Closes #5179
-
- Jan 11, 2018
-
-
Marijn Haverbeke authored
Issue #5177
-
- Jan 10, 2018
-
-
neon-dev authored
If you try to autocomplete at line 0, column 0 after previoulsy having edited for example a WHERE clause, the autocompletion triggers with an invalid position, since prevItem is null. Maybe my fix isn't the best solution, and you could even avoid to enter findTableByAlias enitrely, I don't know.
-
neon-dev authored
Show column hints (if a defaultTable is set) above table hints, since you are far more often in clauses where you need those.
-
Marijn Haverbeke authored
Closes #5174
-
- Dec 14, 2017
-
-
Sorab Bisht authored
-
- Dec 03, 2017
-
-
Marijn Haverbeke authored
-
- Dec 01, 2017
-
-
Marijn Haverbeke authored
Closes #5106
-
- Nov 27, 2017
-
-
Marijn Haverbeke authored
-
Marijn Haverbeke authored
Closes #5095
-
- Nov 20, 2017
-
-
Marijn Haverbeke authored
Issue #4792
-
- Nov 07, 2017
-
-
Marijn Haverbeke authored
Stop relying on mode tokens, use simple heuristic of not being after a word char Issue #5058 Issue #2657
-
- Nov 01, 2017
-
-
Alexander Shvets authored
-
Marijn Haverbeke authored
Closes #5059
-
- Oct 30, 2017
-
-
Jonathan Hart authored
Per #5030, when adding new items to the middle of a Markdown list, the remaining list numbers should automatically increment
-
- Oct 29, 2017
-
-
Marijn Haverbeke authored
Issue #5054
-
Marijn Haverbeke authored
To also make sure the last token isn't a string. Issue codemirror/google-modes#74
-
- Oct 18, 2017
-
-
Markus Olsson authored
The markdown mode uses `CodeMirror.innerMode` which isn't defined in the stripped down node runmode. Since markdown is the only mode (AFAICT) that uses it I'm not sure if it would make more sense rewrite it to not use it but this seemed like the least risky option.
-
- Oct 16, 2017
-
-
Guan Gui authored
Issue #5031
-