Skip to content
Snippets Groups Projects
  1. Jul 30, 2018
    • alecmocatta's avatar
    • alecmocatta's avatar
      FIO* for *-apple-* · 25498ef5
      alecmocatta authored
      25498ef5
    • bors's avatar
      Auto merge of #1044 - faern:modern-alignment, r=alexcrichton · 85657553
      bors authored
      Add alignment feature and use #[repr(align(x))]
      
      Trying to solve #1042.
      
      Here I introduce the discussed feature that will allow going from struct alignment with a private `__align` field to using `#[repr(align(x))]`. However, I have not implemented it for all structs that require alignment yet, only `in6_addr`. This because I did not want to spend too much time before we have discussed and solved the remaining questions regarding this.
      
      One thing to discuss is testing. I have so far not done anything to the CI scripts. So currently they will still test the crate only with the `align` feature disabled. Thus they will make sure the `__align` fields are still correct. But no automatic tests make sure everything is correct when the `align` feature is turned on. What do we want to do about that? Can we insert another `cargo test` with `--features align` to make all the Travis jobs run the test suite twice, or will that slow things down too much?
      
      I have tried using this version of libc in rustc and the standard library. And successfully changed `Ipv6Addr::new` to not use any `unsafe` and to become a `const fn`. Whether or not we want that is out of scope for this PR, but my point was that the changes introduced with this PR allow much more flexible usage of the libc structs that have alignment.
      85657553
    • Linus Färnstrand's avatar
      e167a735
  2. Jul 29, 2018
  3. Jul 22, 2018
  4. Jul 21, 2018
  5. Jul 18, 2018
  6. Jul 17, 2018
  7. Jul 16, 2018
  8. Jul 14, 2018
  9. Jul 12, 2018
  10. Jul 10, 2018
  11. Jul 09, 2018
  12. Jul 08, 2018
  13. Jul 06, 2018
Loading