Skip to content
Snippets Groups Projects
  1. Feb 24, 2019
  2. Feb 22, 2019
    • bors's avatar
      Auto merge of #1274 - gnzlbg:clean_libctest_apple, r=gnzlbg · 68701e7e
      bors authored
      Clean libc-test for apple targets
      
      This cleans up the build.rs of `libc-test` for apple targets.
      
      I wanted to update the docker containers of some targets so that we can start testing newer currently-skipped APIs properly, but it is impossible to figure out which headers and APIs are skipped for each target, which has to change if we update the glibc version in one Linux container but not the other (updating them all at once is just madness).
      
      This PR separates the testing of apple targets into its own self-contained function. This allows seeing exactly which headers are included, and which items are skipped. A lot of work will be required to separate the testing of all major platforms and make the script reasonable.
      
      During the clean up, I discovered that, at least for apple targets, deprecated but not removed APIs are not tested. I re-enabled testing for those, and fixed `daemon`, which was not properly linking its symbol. I also added the `#[deprecated]` attribute to the `#[deprecated]` APIs of the apple targets. The attribute is available since Rust 1.9.0 and the min. Rust version we support is Rust 1.13.0.
      
      Many other APIs are also currently not tested "because they are weird" which I interpret as "the test failed for an unknown reason", as a consequence:
      
      * the signatures of execv, execve, and execvp are incorrect (see https://github.com/rust-lang/libc/issues/1272)
      
      * the `sig_t` type is called `sighandler_t` in libc for some reason: https://github.com/rust-lang/libc/issues/1273
      
      This probably explains why some other things, like the `sa_handler`/`sa_sigaction` fields of `sigaction` were skipped. The field is actually a union, which can be either a `sig_t` for the `sa_handler` field, or some other type for the `sa_sigaction` field, but because the distinction was not made, the field was not checked.
      
      The latest ctest version can check volatile pointers, so a couple of skipped tests are now tested using this feature.
      68701e7e
    • gnzlbg's avatar
      Clean libc-test for apple targets · f5cbdbc2
      gnzlbg authored
      This cleans up the build.rs of `libc-test` for apple targets.
      
      I wanted to update the docker containers of some targets so that we can start
      testing newer currently-skipped APIs properly, but it is impossible to figure
      out which headers and APIs are skipped for each target.
      
      This PR separates the testing of apple targets into its own self-contained
      function. This allows seeing exactly which headers are included, and which items
      are skipped. A lot of work will be required to separate the testing of all major
      platforms and make the script reasonable.
      
      During the clean up, I discovered that, at least for apple targets, deprecated
      but not removed APIs are not tested. I re-enabled testing for those, and fixed
      `daemon`, which was not properly linking its symbol. I also added the
      `#[deprecated]` attribute to the `#[deprecated]` APIs of the apple targets. The
      attribute is available since Rust 1.9.0 and the min. Rust version we support is
      Rust 1.13.0.
      
      Many other APIs are also currently not tested "because they are weird" which I
      interpret as "the test failed for an unknown reason", as a consequence:
      
      * the signatures of execv, execve, and execvp are incorrect (see
        https://github.com/rust-lang/libc/issues/1272)
      
      * the `sig_t` type is called `sighandler_t` in libc for some reason:
        https://github.com/rust-lang/libc/issues/1273
      
      This probably explains why some other things, like the
      `sa_handler`/`sa_sigaction` fields of `sigaction` were skipped. The field is
      actually a union, which can be either a `sig_t` for the `sa_handler` field, or
      some other type for the `sa_sigaction` field, but because the distinction was
      not made, the field was not checked.
      
      The latest ctest version can check volatile pointers, so a couple of skipped
      tests are now tested using this feature.
      f5cbdbc2
    • bors's avatar
      Auto merge of #1270 - gnzlbg:no_extern_std, r=gnzlbg · 400372d7
      bors authored
      Do not import the std library with use_std
      400372d7
    • bors's avatar
      Auto merge of #1269 - gnzlbg:fix_cp_pub, r=gnzlbg · 8c571e0c
      bors authored
      Unnecessary pub use when private module use is available
      
      Addresses part of #1266
      8c571e0c
  3. Feb 21, 2019
  4. Feb 20, 2019
  5. Feb 19, 2019
Loading