-
- Downloads
[breaking change] incorrect API of gettimeofday
The second argument of `gettimeofday` was a `*mut c_void` on all targets, but that type is incorrect in the following targets, where it should be a `*mut timezone` instead: On these other targets it appears that the signature of gettimeofday was incorrect (it takes a time-zone pointer instead of a void pointer): linux+gnu: http://man7.org/linux/man-pages/man2/gettimeofday.2.html freebsd: https://www.freebsd.org/cgi/man.cgi?query=gettimeofday&apropos=0&sektion=2&manpath=FreeBSD+11.2-stable&arch=default&format=html openbsd: https://man.openbsd.org/gettimeofday.2 android: https://github.com/ricardoquesada/android-ndk/blob/master/usr/include/sys/time.h dragonfly: https://www.dragonflybsd.org/cgi/web-man?command=gettimeofday§ion=2 This commit corrects the type on these targets, which is a breaking change. Due to how this API is commonly used (e.g. passing `ptr::null_mut` to the second argument), breakage should be minimal. Users wanting to support both versions can just write `ptr as *mut _` instead. Closes #1338.
Showing
- libc-test/build.rs 2 additions, 17 deletionslibc-test/build.rs
- src/unix/bsd/apple/mod.rs 2 additions, 0 deletionssrc/unix/bsd/apple/mod.rs
- src/unix/bsd/freebsdlike/mod.rs 2 additions, 1 deletionsrc/unix/bsd/freebsdlike/mod.rs
- src/unix/bsd/netbsdlike/netbsd/mod.rs 3 additions, 0 deletionssrc/unix/bsd/netbsdlike/netbsd/mod.rs
- src/unix/bsd/netbsdlike/openbsdlike/mod.rs 2 additions, 0 deletionssrc/unix/bsd/netbsdlike/openbsdlike/mod.rs
- src/unix/haiku/mod.rs 2 additions, 1 deletionsrc/unix/haiku/mod.rs
- src/unix/hermit/mod.rs 2 additions, 0 deletionssrc/unix/hermit/mod.rs
- src/unix/mod.rs 0 additions, 11 deletionssrc/unix/mod.rs
- src/unix/newlib/mod.rs 2 additions, 0 deletionssrc/unix/newlib/mod.rs
- src/unix/notbsd/android/mod.rs 2 additions, 0 deletionssrc/unix/notbsd/android/mod.rs
- src/unix/notbsd/emscripten/mod.rs 3 additions, 0 deletionssrc/unix/notbsd/emscripten/mod.rs
- src/unix/notbsd/linux/musl/mod.rs 2 additions, 0 deletionssrc/unix/notbsd/linux/musl/mod.rs
- src/unix/notbsd/linux/other/mod.rs 2 additions, 0 deletionssrc/unix/notbsd/linux/other/mod.rs
- src/unix/notbsd/mod.rs 0 additions, 1 deletionsrc/unix/notbsd/mod.rs
- src/unix/redox/mod.rs 2 additions, 0 deletionssrc/unix/redox/mod.rs
- src/unix/solarish/mod.rs 2 additions, 0 deletionssrc/unix/solarish/mod.rs
- src/unix/uclibc/mod.rs 2 additions, 0 deletionssrc/unix/uclibc/mod.rs
Loading
Please register or sign in to comment