From 483bb8171fc903b3a27a87b7fdc93797a9809e3f Mon Sep 17 00:00:00 2001 From: Yuki Okushi <huyuumi.dev@gmail.com> Date: Sat, 29 Feb 2020 13:36:27 +0900 Subject: [PATCH] Replace TODO with FIXME to make grep easy --- ci/emscripten.sh | 2 +- src/cloudabi/mod.rs | 2 +- src/fuchsia/mod.rs | 10 +++++----- src/unix/haiku/mod.rs | 4 ++-- src/unix/linux_like/emscripten/mod.rs | 4 ++-- .../linux_like/linux/gnu/b64/aarch64/mod.rs | 2 +- src/unix/linux_like/linux/mod.rs | 2 +- src/unix/linux_like/linux/musl/mod.rs | 2 +- src/unix/linux_like/mod.rs | 4 ++-- src/unix/mod.rs | 2 +- src/unix/redox/mod.rs | 12 +++++------ src/unix/uclibc/mod.rs | 6 +++--- src/unix/uclibc/x86_64/align.rs | 12 +++++------ src/unix/uclibc/x86_64/mod.rs | 20 +++++++++---------- src/unix/uclibc/x86_64/no_align.rs | 12 +++++------ src/vxworks/mod.rs | 2 +- src/windows/mod.rs | 2 +- 17 files changed, 50 insertions(+), 50 deletions(-) diff --git a/ci/emscripten.sh b/ci/emscripten.sh index acec4ca2..3c2650c3 100644 --- a/ci/emscripten.sh +++ b/ci/emscripten.sh @@ -30,7 +30,7 @@ exit 1 git clone https://github.com/emscripten-core/emsdk.git /emsdk-portable cd /emsdk-portable -# TODO: switch to an upstream install once +# FIXME: switch to an upstream install once # https://github.com/rust-lang/rust/pull/63649 lands hide_output ./emsdk install 1.38.42 ./emsdk activate 1.38.42 diff --git a/src/cloudabi/mod.rs b/src/cloudabi/mod.rs index 71f6ff45..77817121 100644 --- a/src/cloudabi/mod.rs +++ b/src/cloudabi/mod.rs @@ -120,7 +120,7 @@ impl ::Clone for FILE { } } #[cfg_attr(feature = "extra_traits", derive(Debug))] -pub enum fpos_t {} // TODO: fill this out with a struct +pub enum fpos_t {} // FIXME: fill this out with a struct impl ::Copy for fpos_t {} impl ::Clone for fpos_t { fn clone(&self) -> fpos_t { diff --git a/src/fuchsia/mod.rs b/src/fuchsia/mod.rs index c4467a8e..a560f7d3 100644 --- a/src/fuchsia/mod.rs +++ b/src/fuchsia/mod.rs @@ -109,7 +109,7 @@ impl ::Clone for DIR { } #[cfg_attr(feature = "extra_traits", derive(Debug))] -pub enum fpos64_t {} // TODO: fill this out with a struct +pub enum fpos64_t {} // FIXME: fill this out with a struct impl ::Copy for fpos64_t {} impl ::Clone for fpos64_t { fn clone(&self) -> fpos64_t { @@ -1416,7 +1416,7 @@ pub const F_SEAL_SHRINK: ::c_int = 0x0002; pub const F_SEAL_GROW: ::c_int = 0x0004; pub const F_SEAL_WRITE: ::c_int = 0x0008; -// TODO(#235): Include file sealing fcntls once we have a way to verify them. +// FIXME(#235): Include file sealing fcntls once we have a way to verify them. pub const SIGTRAP: ::c_int = 5; @@ -1433,7 +1433,7 @@ pub const CLOCK_MONOTONIC_COARSE: ::clockid_t = 6; pub const CLOCK_BOOTTIME: ::clockid_t = 7; pub const CLOCK_REALTIME_ALARM: ::clockid_t = 8; pub const CLOCK_BOOTTIME_ALARM: ::clockid_t = 9; -// TODO(#247) Someday our Travis shall have glibc 2.21 (released in Sep +// FIXME(#247) Someday our Travis shall have glibc 2.21 (released in Sep // 2014.) See also musl/mod.rs // pub const CLOCK_SGI_CYCLE: ::clockid_t = 10; // pub const CLOCK_TAI: ::clockid_t = 11; @@ -2773,7 +2773,7 @@ pub const TIOCINQ: ::c_int = ::FIONREAD; pub const RTLD_GLOBAL: ::c_int = 0x100; pub const RTLD_NOLOAD: ::c_int = 0x4; -// TODO(#247) Temporarily musl-specific (available since musl 0.9.12 / Linux +// FIXME(#247) Temporarily musl-specific (available since musl 0.9.12 / Linux // kernel 3.10). See also notbsd/mod.rs pub const CLOCK_SGI_CYCLE: ::clockid_t = 10; pub const CLOCK_TAI: ::clockid_t = 11; @@ -3273,7 +3273,7 @@ impl ::Clone for FILE { } } #[cfg_attr(feature = "extra_traits", derive(Debug))] -pub enum fpos_t {} // TODO: fill this out with a struct +pub enum fpos_t {} // FIXME: fill this out with a struct impl ::Copy for fpos_t {} impl ::Clone for fpos_t { fn clone(&self) -> fpos_t { diff --git a/src/unix/haiku/mod.rs b/src/unix/haiku/mod.rs index 5cbbfe9c..95adabdf 100644 --- a/src/unix/haiku/mod.rs +++ b/src/unix/haiku/mod.rs @@ -662,7 +662,7 @@ pub const LC_NUMERIC: ::c_int = 4; pub const LC_TIME: ::c_int = 5; pub const LC_MESSAGES: ::c_int = 6; -// TODO: Haiku does not have MAP_FILE, but libstd/os.rs requires it +// FIXME: Haiku does not have MAP_FILE, but libstd/os.rs requires it pub const MAP_FILE: ::c_int = 0x00; pub const MAP_SHARED: ::c_int = 0x01; pub const MAP_PRIVATE: ::c_int = 0x02; @@ -994,7 +994,7 @@ pub const PTHREAD_MUTEX_NORMAL: ::c_int = 1; pub const PTHREAD_MUTEX_ERRORCHECK: ::c_int = 2; pub const PTHREAD_MUTEX_RECURSIVE: ::c_int = 3; -pub const FIOCLEX: c_ulong = 0; // TODO: does not exist on Haiku! +pub const FIOCLEX: c_ulong = 0; // FIXME: does not exist on Haiku! pub const RUSAGE_CHILDREN: ::c_int = -1; diff --git a/src/unix/linux_like/emscripten/mod.rs b/src/unix/linux_like/emscripten/mod.rs index 3fc47bb5..382b83e6 100644 --- a/src/unix/linux_like/emscripten/mod.rs +++ b/src/unix/linux_like/emscripten/mod.rs @@ -35,7 +35,7 @@ pub type c_ulong = u32; pub type nlink_t = u32; #[cfg_attr(feature = "extra_traits", derive(Debug))] -pub enum fpos64_t {} // TODO: fill this out with a struct +pub enum fpos64_t {} // FIXME: fill this out with a struct impl ::Copy for fpos64_t {} impl ::Clone for fpos64_t { fn clone(&self) -> fpos64_t { @@ -1286,7 +1286,7 @@ pub const TIOCINQ: ::c_int = ::FIONREAD; pub const RTLD_GLOBAL: ::c_int = 0x100; pub const RTLD_NOLOAD: ::c_int = 0x4; -// TODO(#247) Temporarily musl-specific (available since musl 0.9.12 / Linux +// FIXME(#247) Temporarily musl-specific (available since musl 0.9.12 / Linux // kernel 3.10). See also linux_like/mod.rs pub const CLOCK_SGI_CYCLE: ::clockid_t = 10; pub const CLOCK_TAI: ::clockid_t = 11; diff --git a/src/unix/linux_like/linux/gnu/b64/aarch64/mod.rs b/src/unix/linux_like/linux/gnu/b64/aarch64/mod.rs index 90eec93b..0cab5144 100644 --- a/src/unix/linux_like/linux/gnu/b64/aarch64/mod.rs +++ b/src/unix/linux_like/linux/gnu/b64/aarch64/mod.rs @@ -695,7 +695,7 @@ pub const HWCAP_SSBS: ::c_ulong = 1 << 28; pub const HWCAP_SB: ::c_ulong = 1 << 29; pub const HWCAP_PACA: ::c_ulong = 1 << 30; pub const HWCAP_PACG: ::c_ulong = 1 << 31; -// TODO: enable these again once linux-api-headers are up to date enough on CI. +// FIXME: enable these again once linux-api-headers are up to date enough on CI. // See discussion in https://github.com/rust-lang/libc/pull/1638 //pub const HWCAP2_DCPODP: ::c_ulong = 1 << 0; //pub const HWCAP2_SVE2: ::c_ulong = 1 << 1; diff --git a/src/unix/linux_like/linux/mod.rs b/src/unix/linux_like/linux/mod.rs index 3e2a9ff7..10dd5ec4 100644 --- a/src/unix/linux_like/linux/mod.rs +++ b/src/unix/linux_like/linux/mod.rs @@ -37,7 +37,7 @@ pub type Elf32_Section = u16; pub type Elf64_Section = u16; #[cfg_attr(feature = "extra_traits", derive(Debug))] -pub enum fpos64_t {} // TODO: fill this out with a struct +pub enum fpos64_t {} // FIXME: fill this out with a struct impl ::Copy for fpos64_t {} impl ::Clone for fpos64_t { fn clone(&self) -> fpos64_t { diff --git a/src/unix/linux_like/linux/musl/mod.rs b/src/unix/linux_like/linux/musl/mod.rs index 0bddd64a..baaf1a8e 100644 --- a/src/unix/linux_like/linux/musl/mod.rs +++ b/src/unix/linux_like/linux/musl/mod.rs @@ -327,7 +327,7 @@ pub const TCSAFLUSH: ::c_int = 2; pub const RTLD_GLOBAL: ::c_int = 0x100; pub const RTLD_NOLOAD: ::c_int = 0x4; -// TODO(#247) Temporarily musl-specific (available since musl 0.9.12 / Linux +// FIXME(#247) Temporarily musl-specific (available since musl 0.9.12 / Linux // kernel 3.10). See also linux_like/mod.rs pub const CLOCK_SGI_CYCLE: ::clockid_t = 10; pub const CLOCK_TAI: ::clockid_t = 11; diff --git a/src/unix/linux_like/mod.rs b/src/unix/linux_like/mod.rs index f9c5ea5d..3c36b68f 100644 --- a/src/unix/linux_like/mod.rs +++ b/src/unix/linux_like/mod.rs @@ -482,7 +482,7 @@ pub const F_SEAL_SHRINK: ::c_int = 0x0002; pub const F_SEAL_GROW: ::c_int = 0x0004; pub const F_SEAL_WRITE: ::c_int = 0x0008; -// TODO(#235): Include file sealing fcntls once we have a way to verify them. +// FIXME(#235): Include file sealing fcntls once we have a way to verify them. pub const SIGTRAP: ::c_int = 5; @@ -499,7 +499,7 @@ pub const CLOCK_MONOTONIC_COARSE: ::clockid_t = 6; pub const CLOCK_BOOTTIME: ::clockid_t = 7; pub const CLOCK_REALTIME_ALARM: ::clockid_t = 8; pub const CLOCK_BOOTTIME_ALARM: ::clockid_t = 9; -// TODO(#247) Someday our Travis shall have glibc 2.21 (released in Sep +// FIXME(#247) Someday our Travis shall have glibc 2.21 (released in Sep // 2014.) See also musl/mod.rs // pub const CLOCK_SGI_CYCLE: ::clockid_t = 10; // pub const CLOCK_TAI: ::clockid_t = 11; diff --git a/src/unix/mod.rs b/src/unix/mod.rs index e1e9e499..6d3ef944 100644 --- a/src/unix/mod.rs +++ b/src/unix/mod.rs @@ -365,7 +365,7 @@ impl ::Clone for FILE { } } #[cfg_attr(feature = "extra_traits", derive(Debug))] -pub enum fpos_t {} // TODO: fill this out with a struct +pub enum fpos_t {} // FIXME: fill this out with a struct impl ::Copy for fpos_t {} impl ::Clone for fpos_t { fn clone(&self) -> fpos_t { diff --git a/src/unix/redox/mod.rs b/src/unix/redox/mod.rs index 4ea52e37..7f66f1b4 100644 --- a/src/unix/redox/mod.rs +++ b/src/unix/redox/mod.rs @@ -258,7 +258,7 @@ pub const F_GETLK: ::c_int = 5; pub const F_SETLK: ::c_int = 6; pub const F_SETLKW: ::c_int = 7; -// TODO: relibc { +// FIXME: relibc { pub const RTLD_DEFAULT: *mut ::c_void = 0i64 as *mut ::c_void; // } @@ -413,7 +413,7 @@ pub const F_GETFD: ::c_int = 1; pub const F_SETFD: ::c_int = 2; pub const F_GETFL: ::c_int = 3; pub const F_SETFL: ::c_int = 4; -// TODO: relibc { +// FIXME: relibc { pub const F_DUPFD_CLOEXEC: ::c_int = ::F_DUPFD; // } pub const FD_CLOEXEC: ::c_int = 0x0100_0000; @@ -435,14 +435,14 @@ pub const O_DIRECTORY: ::c_int = 0x1000_0000; pub const O_PATH: ::c_int = 0x2000_0000; pub const O_SYMLINK: ::c_int = 0x4000_0000; // Negative to allow it to be used as int -// TODO: Fix negative values missing from includes +// FIXME: Fix negative values missing from includes pub const O_NOFOLLOW: ::c_int = -0x8000_0000; // netdb.h pub const EAI_SYSTEM: ::c_int = -11; // netinet/in.h -// TODO: relibc { +// FIXME: relibc { pub const IP_TTL: ::c_int = 2; pub const IPV6_UNICAST_HOPS: ::c_int = 16; pub const IPV6_MULTICAST_IF: ::c_int = 17; @@ -460,7 +460,7 @@ pub const IP_DROP_MEMBERSHIP: ::c_int = 36; // netinet/tcp.h pub const TCP_NODELAY: ::c_int = 1; -// TODO: relibc { +// FIXME: relibc { pub const TCP_KEEPIDLE: ::c_int = 1; // } @@ -575,7 +575,7 @@ pub const EXIT_SUCCESS: ::c_int = 0; pub const EXIT_FAILURE: ::c_int = 1; // sys/ioctl.h -// TODO: relibc { +// FIXME: relibc { pub const FIONBIO: ::c_ulong = 0x5421; pub const FIOCLEX: ::c_ulong = 0x5451; // } diff --git a/src/unix/uclibc/mod.rs b/src/unix/uclibc/mod.rs index 3f779aa6..82500d79 100644 --- a/src/unix/uclibc/mod.rs +++ b/src/unix/uclibc/mod.rs @@ -23,7 +23,7 @@ pub type nl_item = ::c_int; pub type idtype_t = ::c_uint; #[cfg_attr(feature = "extra_traits", derive(Debug))] -pub enum fpos64_t {} // TODO: fill this out with a struct +pub enum fpos64_t {} // FIXME: fill this out with a struct impl ::Copy for fpos64_t {} impl ::Clone for fpos64_t { fn clone(&self) -> fpos64_t { @@ -501,7 +501,7 @@ pub const F_GETLEASE: ::c_int = 1025; pub const F_NOTIFY: ::c_int = 1026; pub const F_DUPFD_CLOEXEC: ::c_int = 1030; -// TODO(#235): Include file sealing fcntls once we have a way to verify them. +// FIXME(#235): Include file sealing fcntls once we have a way to verify them. pub const SIGTRAP: ::c_int = 5; @@ -512,7 +512,7 @@ pub const CLOCK_REALTIME: ::clockid_t = 0; pub const CLOCK_MONOTONIC: ::clockid_t = 1; pub const CLOCK_PROCESS_CPUTIME_ID: ::clockid_t = 2; pub const CLOCK_THREAD_CPUTIME_ID: ::clockid_t = 3; -// TODO(#247) Someday our Travis shall have glibc 2.21 (released in Sep +// FIXME(#247) Someday our Travis shall have glibc 2.21 (released in Sep // 2014.) See also musl/mod.rs // pub const CLOCK_SGI_CYCLE: ::clockid_t = 10; // pub const CLOCK_TAI: ::clockid_t = 11; diff --git a/src/unix/uclibc/x86_64/align.rs b/src/unix/uclibc/x86_64/align.rs index 583a278d..e2d829b5 100644 --- a/src/unix/uclibc/x86_64/align.rs +++ b/src/unix/uclibc/x86_64/align.rs @@ -5,7 +5,7 @@ macro_rules! expand_align { repr(align(4)))] #[cfg_attr(target_pointer_width = "64", repr(align(8)))] - pub struct sem_t { // ToDo + pub struct sem_t { // FIXME #[cfg(target_pointer_width = "32")] __size: [::c_char; 16], #[cfg(target_pointer_width = "64")] @@ -26,12 +26,12 @@ macro_rules! expand_align { target_arch = "s390x", target_arch = "sparc64")), repr(align(8)))] - pub struct pthread_mutexattr_t { // ToDo + pub struct pthread_mutexattr_t { // FIXME size: [u8; ::__SIZEOF_PTHREAD_MUTEXATTR_T], } #[repr(align(4))] - pub struct pthread_condattr_t { // ToDo + pub struct pthread_condattr_t { // FIXME size: [u8; ::__SIZEOF_PTHREAD_CONDATTR_T], } } @@ -48,13 +48,13 @@ macro_rules! expand_align { target_arch = "powerpc")))), repr(align(8)))] #[allow(missing_debug_implementations)] - pub struct pthread_mutex_t { // ToDo + pub struct pthread_mutex_t { // FIXME size: [u8; ::__SIZEOF_PTHREAD_MUTEX_T], } #[repr(align(8))] #[allow(missing_debug_implementations)] - pub struct pthread_cond_t { // ToDo + pub struct pthread_cond_t { // FIXME size: [u8; ::__SIZEOF_PTHREAD_COND_T], } @@ -69,7 +69,7 @@ macro_rules! expand_align { target_arch = "powerpc"))), repr(align(8)))] #[allow(missing_debug_implementations)] - pub struct pthread_rwlock_t { // ToDo + pub struct pthread_rwlock_t { // FIXME size: [u8; ::__SIZEOF_PTHREAD_RWLOCK_T], } } diff --git a/src/unix/uclibc/x86_64/mod.rs b/src/unix/uclibc/x86_64/mod.rs index a8bb0794..26eca9e7 100644 --- a/src/unix/uclibc/x86_64/mod.rs +++ b/src/unix/uclibc/x86_64/mod.rs @@ -147,13 +147,13 @@ s! { pub sa_mask: ::sigset_t, } - pub struct stack_t { // ToDo + pub struct stack_t { // FIXME pub ss_sp: *mut ::c_void, pub ss_flags: ::c_int, pub ss_size: ::size_t } - pub struct statfs { // ToDo + pub struct statfs { // FIXME pub f_type: fsword_t, pub f_bsize: fsword_t, pub f_blocks: ::fsblkcnt_t, @@ -167,7 +167,7 @@ s! { f_spare: [fsword_t; 5], } - pub struct msghdr { // ToDo + pub struct msghdr { // FIXME pub msg_name: *mut ::c_void, pub msg_namelen: ::socklen_t, pub msg_iov: *mut ::iovec, @@ -177,7 +177,7 @@ s! { pub msg_flags: ::c_int, } - pub struct termios { // ToDo + pub struct termios { // FIXME pub c_iflag: ::tcflag_t, pub c_oflag: ::tcflag_t, pub c_cflag: ::tcflag_t, @@ -186,11 +186,11 @@ s! { pub c_cc: [::cc_t; ::NCCS], } - pub struct sigset_t { // ToDo + pub struct sigset_t { // FIXME __val: [::c_ulong; 16], } - pub struct sysinfo { // ToDo + pub struct sysinfo { // FIXME pub uptime: ::c_long, pub loads: [::c_ulong; 3], pub totalram: ::c_ulong, @@ -207,7 +207,7 @@ s! { pub _f: [::c_char; 0], } - pub struct glob_t { // ToDo + pub struct glob_t { // FIXME pub gl_pathc: ::size_t, pub gl_pathv: *mut *mut c_char, pub gl_offs: ::size_t, @@ -219,19 +219,19 @@ s! { __unused5: *mut ::c_void, } - pub struct rlimit64 { // ToDo + pub struct rlimit64 { // FIXME pub rlim_cur: rlim64_t, pub rlim_max: rlim64_t, } - pub struct cpu_set_t { // ToDo + pub struct cpu_set_t { // FIXME #[cfg(target_pointer_width = "32")] bits: [u32; 32], #[cfg(target_pointer_width = "64")] bits: [u64; 16], } - pub struct fsid_t { // ToDo + pub struct fsid_t { // FIXME __val: [::c_int; 2], } } diff --git a/src/unix/uclibc/x86_64/no_align.rs b/src/unix/uclibc/x86_64/no_align.rs index 422d78fa..ffa4e523 100644 --- a/src/unix/uclibc/x86_64/no_align.rs +++ b/src/unix/uclibc/x86_64/no_align.rs @@ -1,7 +1,7 @@ macro_rules! expand_align { () => { s! { - pub struct sem_t { // ToDo + pub struct sem_t { // FIXME #[cfg(target_pointer_width = "32")] __size: [::c_char; 16], #[cfg(target_pointer_width = "64")] @@ -9,7 +9,7 @@ macro_rules! expand_align { __align: [::c_long; 0], } - pub struct pthread_mutex_t { // ToDo + pub struct pthread_mutex_t { // FIXME #[cfg(any(target_arch = "mips", target_arch = "arm", target_arch = "powerpc"))] @@ -21,7 +21,7 @@ macro_rules! expand_align { size: [u8; ::__SIZEOF_PTHREAD_MUTEX_T], } - pub struct pthread_mutexattr_t { // ToDo + pub struct pthread_mutexattr_t { // FIXME #[cfg(any(target_arch = "x86_64", target_arch = "powerpc64", target_arch = "mips64", target_arch = "s390x", target_arch = "sparc64"))] @@ -33,17 +33,17 @@ macro_rules! expand_align { size: [u8; ::__SIZEOF_PTHREAD_MUTEXATTR_T], } - pub struct pthread_cond_t { // ToDo + pub struct pthread_cond_t { // FIXME __align: [::c_longlong; 0], size: [u8; ::__SIZEOF_PTHREAD_COND_T], } - pub struct pthread_condattr_t { // ToDo + pub struct pthread_condattr_t { // FIXME __align: [::c_int; 0], size: [u8; ::__SIZEOF_PTHREAD_CONDATTR_T], } - pub struct pthread_rwlock_t { // ToDo + pub struct pthread_rwlock_t { // FIXME #[cfg(any(target_arch = "mips", target_arch = "arm", target_arch = "powerpc"))] diff --git a/src/vxworks/mod.rs b/src/vxworks/mod.rs index f0c11802..2ca38d5e 100755 --- a/src/vxworks/mod.rs +++ b/src/vxworks/mod.rs @@ -1009,7 +1009,7 @@ impl ::Clone for FILE { } } #[cfg_attr(feature = "extra_traits", derive(Debug))] -pub enum fpos_t {} // TODO: fill this out with a struct +pub enum fpos_t {} // FIXME: fill this out with a struct impl ::Copy for fpos_t {} impl ::Clone for fpos_t { fn clone(&self) -> fpos_t { diff --git a/src/windows/mod.rs b/src/windows/mod.rs index 2fe1d01d..fcbe0bf7 100644 --- a/src/windows/mod.rs +++ b/src/windows/mod.rs @@ -250,7 +250,7 @@ impl ::Clone for FILE { } } #[cfg_attr(feature = "extra_traits", derive(Debug))] -pub enum fpos_t {} // TODO: fill this out with a struct +pub enum fpos_t {} // FIXME: fill this out with a struct impl ::Copy for fpos_t {} impl ::Clone for fpos_t { fn clone(&self) -> fpos_t { -- GitLab